linux-kernel - Re: [PATCH bpf-next v3 6/6] bpf: selftests: Add defrag selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2023 17:37:01 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Daniel Xu <dxu@...uu.xyz>
Cc:     Andrii Nakryiko <andrii@...nel.org>, Shuah Khan <shuah@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Florian Westphal <fw@...len.de>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Mykola Lysenko <mykolal@...com>,
        LKML <linux-kernel@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        netfilter-devel <netfilter-devel@...r.kernel.org>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH bpf-next v3 6/6] bpf: selftests: Add defrag selftests

On Fri, Jul 7, 2023 at 9:51 AM Daniel Xu <dxu@...uu.xyz> wrote:
>
> These selftests tests 2 major scenarios: the BPF based defragmentation
> can successfully be done and that packet pointers are invalidated after
> calls to the kfunc. The logic is similar for both ipv4 and ipv6.
>
> In the first scenario, we create a UDP client and UDP echo server. The
> the server side is fairly straightforward: we attach the prog and simply
> echo back the message.
>
> The on the client side, we send fragmented packets to and expect the
> reassembled message back from the server.
>
> Signed-off-by: Daniel Xu <dxu@...uu.xyz>

The patches look good, but new tests are failing on arm64.

test_bpf_ip_check_defrag_ok:FAIL:server recvfrom unexpected server
recvfrom: actual -1 < expected 0

see BPF CI.
Feels like a timing issue, but pls take a look.