linux-kernel - Re: [PATCH v4 2/5] fs: Add fchmodat2()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230711-spendabel-lotosblume-f08d23a83ebf@brauner>
Date:   Tue, 11 Jul 2023 19:05:44 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Alexey Gladkov <legion@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
        linux-api@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        viro@...iv.linux.org.uk, James.Bottomley@...senPartnership.com,
        acme@...nel.org, alexander.shishkin@...ux.intel.com,
        axboe@...nel.dk, benh@...nel.crashing.org, borntraeger@...ibm.com,
        bp@...en8.de, catalin.marinas@....com, christian@...uner.io,
        dalias@...c.org, davem@...emloft.net, deepa.kernel@...il.com,
        deller@....de, dhowells@...hat.com, fenghua.yu@...el.com,
        fweimer@...hat.com, geert@...ux-m68k.org, glebfm@...linux.org,
        gor@...ux.ibm.com, hare@...e.com, hpa@...or.com,
        ink@...assic.park.msu.ru, jhogan@...nel.org, kim.phillips@....com,
        ldv@...linux.org, linux-alpha@...r.kernel.org,
        linux-arch@...r.kernel.org, linux-ia64@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
        linux-parisc@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-sh@...r.kernel.org, linux@...linux.org.uk,
        linuxppc-dev@...ts.ozlabs.org, luto@...nel.org, mattst88@...il.com,
        mingo@...hat.com, monstr@...str.eu, mpe@...erman.id.au,
        namhyung@...nel.org, paulus@...ba.org, peterz@...radead.org,
        ralf@...ux-mips.org, sparclinux@...r.kernel.org, stefan@...er.ch,
        tglx@...utronix.de, tony.luck@...el.com, tycho@...ho.ws,
        will@...nel.org, x86@...nel.org, ysato@...rs.sourceforge.jp,
        Palmer Dabbelt <palmer@...ive.com>
Subject: Re: [PATCH v4 2/5] fs: Add fchmodat2()

On Tue, Jul 11, 2023 at 06:16:04PM +0200, Alexey Gladkov wrote:
> On the userspace side fchmodat(3) is implemented as a wrapper
> function which implements the POSIX-specified interface. This
> interface differs from the underlying kernel system call, which does not
> have a flags argument. Most implementations require procfs [1][2].
> 
> There doesn't appear to be a good userspace workaround for this issue
> but the implementation in the kernel is pretty straight-forward.
> 
> The new fchmodat2() syscall allows to pass the AT_SYMLINK_NOFOLLOW flag,
> unlike existing fchmodat.
> 
> [1] https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/fchmodat.c;h=17eca54051ee28ba1ec3f9aed170a62630959143;hb=a492b1e5ef7ab50c6fdd4e4e9879ea5569ab0a6c#l35
> [2] https://git.musl-libc.org/cgit/musl/tree/src/stat/fchmodat.c?id=718f363bc2067b6487900eddc9180c84e7739f80#n28
> 
> Co-developed-by: Palmer Dabbelt <palmer@...ive.com>
> Signed-off-by: Palmer Dabbelt <palmer@...ive.com>
> Signed-off-by: Alexey Gladkov <legion@...nel.org>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> ---
>  fs/open.c                | 18 ++++++++++++++----
>  include/linux/syscalls.h |  2 ++
>  2 files changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/open.c b/fs/open.c
> index 0c55c8e7f837..39a7939f0d00 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -671,11 +671,11 @@ SYSCALL_DEFINE2(fchmod, unsigned int, fd, umode_t, mode)
>  	return err;
>  }
>  
> -static int do_fchmodat(int dfd, const char __user *filename, umode_t mode)
> +static int do_fchmodat(int dfd, const char __user *filename, umode_t mode, int lookup_flags)

Should all be unsigned instead of int here for flags. We also had a
documentation update to that effect but smh never sent it.
user_path_at() itself takes an unsigned as well.

I'll fix that up though.