linux-kernel - Re: [PATCH net-next v2 04/10] net: hns3: remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0663169a-a8f4-daa4-0974-72d10f02b4d7@huawei.com>
Date:   Tue, 11 Jul 2023 10:16:44 +0800
From:   Hao Lan <lanhao@...wei.com>
To:     Su Hui <suhui@...china.com>, <yisen.zhuang@...wei.com>,
        <salil.mehta@...wei.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, wuych <yunchuan@...china.com>
Subject: Re: [PATCH net-next v2 04/10] net: hns3: remove unnecessary (void*)
 conversions



On 2023/7/10 14:40, Su Hui wrote:
> From: wuych <yunchuan@...china.com>
> 
> Pointer variables of void * type do not require type cast.
> 
> Signed-off-by: wuych <yunchuan@...china.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 407d30ee55d2..36858a72d771 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -569,8 +569,8 @@ static void hns3_get_strings(struct net_device *netdev, u32 stringset, u8 *data)
>  
>  static u64 *hns3_get_stats_tqps(struct hnae3_handle *handle, u64 *data)
>  {
> -	struct hns3_nic_priv *nic_priv = (struct hns3_nic_priv *)handle->priv;
>  	struct hnae3_knic_private_info *kinfo = &handle->kinfo;
> +	struct hns3_nic_priv *nic_priv = handle->priv;
>  	struct hns3_enet_ring *ring;
>  	u8 *stat;
>  	int i, j;
> 
Reviewed-by: Hao Lan <lanhao@...wei.com>