linux-kernel - Re: [PATCH v2] lib:Fix more error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5469d33c-8b23-79b0-3815-163908cffb40@infradead.org>
Date:   Tue, 11 Jul 2023 12:33:11 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Wang Ming <machel@...o.com>, linux-kernel@...r.kernel.org
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH v2] lib:Fix more error checking for debugfs_create_dir()

Hi--

On 7/11/23 04:16, Wang Ming wrote:
> In case of failure, debugfs_create_dir() does not return NULL,
> but an error pointer.  Most incorrect error checks were fixed,
> but the one in test_fpu_init() was forgotten.
> 
> Fix the remaining error check.
> 
> Signed-off-by: Wang Ming <machel@...o.com>

You need to send this to some maintainer who can merge it,
so please an appropriate maintainer to send it to.

Thanks.

> ---
>  lib/test_fpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_fpu.c b/lib/test_fpu.c
> index e82db19fed84..5d6aa4691b4a 100644
> --- a/lib/test_fpu.c
> +++ b/lib/test_fpu.c
> @@ -69,7 +69,7 @@ static struct dentry *selftest_dir;
>  static int __init test_fpu_init(void)
>  {
>  	selftest_dir = debugfs_create_dir("selftest_helpers", NULL);
> -	if (!selftest_dir)
> +	if (IS_ERR(selftest_dir))
>  		return -ENOMEM;
>  
>  	debugfs_create_file_unsafe("test_fpu", 0444, selftest_dir, NULL,

-- 
~Randy