linux-kernel - Re: xfs WARNING on v6.5-rc1 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202307111435.1C23ECE259@keescook>
Date:   Tue, 11 Jul 2023 14:37:20 -0700
From:   Kees Cook <keescook@...omium.org>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     Jeff Layton <jlayton@...nel.org>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: xfs WARNING on v6.5-rc1 kernel

On Mon, Jul 10, 2023 at 10:02:43AM -0700, Darrick J. Wong wrote:
> On Mon, Jul 10, 2023 at 12:29:29PM -0400, Jeff Layton wrote:
> > I hit this this morning while running generic/013 (fsstress), with a
> > kernel based on v6.5-rc1. The main changes on top of this are timestamp
> > related, so I doubt they're a factor here.
> > 
> > Is this some of the flexarray hardening?
> 
> Yes.
> 
> https://lore.kernel.org/linux-xfs/ZI+3QXDHiohgv%2FPb@dread.disaster.area/
> https://lore.kernel.org/linux-xfs/bug-217522-201763-D34HpuP9xe@https.bugzilla.kernel.org%2F/
> https://lore.kernel.org/linux-xfs/Y9xiYmVLRIKdpJcC@work/

It looks like these just need struct tweaks to avoid using legacy array
definitions. It can be done without changes to the size of the structs,
etc.

I'll send a patch...

-- 
Kees Cook