linux-kernel - [PATCH] drm/nouveau/devinit: Move assignment outside if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ccc9e4541dcac0675e578825667b60ad@208suo.com>
Date:   Tue, 11 Jul 2023 10:45:57 +0800
From:   sunran001@...suo.com
To:     airlied@...il.com, daniel@...ll.ch
Cc:     dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] drm/nouveau/devinit: Move assignment outside if condition

Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

Signed-off-by: Ran Sun <sunran001@...suo.com>
---
  drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c 
b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
index 1410befd2285..8185e10efc49 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
@@ -61,7 +61,8 @@ nv05_devinit_meminit(struct nvkm_devinit *init)
      }

      strap = (nvkm_rd32(device, 0x101000) & 0x0000003c) >> 2;
-    if ((data = bmp_mem_init_table(bios))) {
+    data = bmp_mem_init_table(bios);
+    if (data) {
          ramcfg[0] = nvbios_rd08(bios, data + 2 * strap + 0);
          ramcfg[1] = nvbios_rd08(bios, data + 2 * strap + 1);
      } else {