[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c3e67df5-c25a-1123-4b64-cd5816a5642e@gmx.de>
Date: Tue, 11 Jul 2023 07:29:22 +0200
From: Helge Deller <deller@....de>
To: Yangtao Li <frank.li@...o.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Shawn Guo <shawnguo@...nel.org>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: linux-fbdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] fbdev: imxfb: Removed unneeded release_mem_region
On 7/10/23 15:19, Yangtao Li wrote:
> Remove unnecessary release_mem_region from the error path to prevent
> mem region from being released twice, which could avoid resource leak
> or other unexpected issues.
>
> Fixes: b083c22d5114 ("video: fbdev: imxfb: Convert request_mem_region + ioremap to devm_ioremap_resource")
> Signed-off-by: Yangtao Li <frank.li@...o.com>
I've applied that series (and fixed minor grammar typos in the commit logs).
Thanks!
Helge
> ---
> drivers/video/fbdev/imxfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
> index 04f3bf30a529..385c4715c7b7 100644
> --- a/drivers/video/fbdev/imxfb.c
> +++ b/drivers/video/fbdev/imxfb.c
> @@ -1043,7 +1043,6 @@ static int imxfb_probe(struct platform_device *pdev)
> failed_map:
> failed_ioremap:
> failed_getclock:
> - release_mem_region(res->start, resource_size(res));
> failed_of_parse:
> kfree(info->pseudo_palette);
> failed_init:
Powered by blists - more mailing lists