[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2040226e-9b45-b409-3edd-a5b86d86daa8@linaro.org>
Date: Tue, 11 Jul 2023 07:52:45 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rohit Agarwal <quic_rohiagar@...cinc.com>, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD
indexes
On 11/07/2023 07:42, Rohit Agarwal wrote:
> Add Generic RPMh Power Domain indexes that can be used
> for all the Qualcomm SoC henceforth.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@...cinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>
> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
> new file mode 100644
> index 0000000..4da2e04
> --- /dev/null
> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
Filename based on compatible.
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
> +
> +/* Generic RPMH Power Domain Indexes */
> +#define CX 0
These are very generic names, usually not used in global headers. Please
use some reasonable prefix.
Best regards,
Krzysztof
Powered by blists - more mailing lists