lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <97436a92-2cbd-0498-8aad-444ac3fab99b@linaro.org>
Date:   Tue, 11 Jul 2023 08:04:02 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jayesh Choudhary <j-choudhary@...com>, peda@...ntia.se,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        s-vadapalli@...com
Subject: Re: [PATCH] dt-bindings: ti-serdes-mux: Add defines for SERDES4 in
 J784S4 SoC

On 11/07/2023 07:55, Jayesh Choudhary wrote:
> Hello Krzysztof,
> 
> On 10/07/23 17:11, Krzysztof Kozlowski wrote:
>> On 10/07/2023 12:27, Jayesh Choudhary wrote:
>>> SERDES4 has 4 lanes. Add lane definitions for it.
>>>
>>> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
>>> ---
>>>   include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++
>>
>> Where are the users of this binding constants? IOW, why do you need to
>> add these?
>>
>> I don't see users of existing constants either...
>>
> 
> These constants are propagated in the idle-state property for the
> mux-controller node (named serdes_ln_ctrl) usually in the final
> board dts files and occasionally in the main dtsi files for TI SoCs.

So they are not used. Do not add headers which are not used - neither to
the kernel sources, nor to the DTSI. The header constants don't even
look as suitable for bindings, although this is tricky to judge without
users.

Best regards,
Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ