linux-kernel - RE: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Jul 2023 06:18:10 +0000
From:   Alok Prasad <palok@...vell.com>
To:     Minjie Du <duminjie@...o.com>,
        "Markus.Elfring@....de" <Markus.Elfring@....de>,
        Michal Kalderon <mkalderon@...vell.com>,
        Ariel Elior <aelior@...vell.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>,
        "open list:QLOGIC QL4xxx RDMA DRIVER" <linux-rdma@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
CC:     "opensource.kernel@...o.com" <opensource.kernel@...o.com>
Subject: RE: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in
 qedr_create_gsi_qp()


> -----Original Message-----
> From: Minjie Du <duminjie@...o.com>
> Sent: 05 July 2023 16:10
> To: Markus.Elfring@....de; Michal Kalderon <mkalderon@...vell.com>; Ariel Elior <aelior@...vell.com>; Jason Gunthorpe
> <jgg@...pe.ca>; Leon Romanovsky <leon@...nel.org>; open list:QLOGIC QL4xxx RDMA DRIVER <linux-rdma@...r.kernel.org>; open
> list <linux-kernel@...r.kernel.org>
> Cc: opensource.kernel@...o.com; Minjie Du <duminjie@...o.com>
> Subject: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()
> 
> Delete a duplicate statement from this function implementation.
> 
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
>  drivers/infiniband/hw/qedr/qedr_roce_cm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/qedr_roce_cm.c b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> index 05307c148..859f66a51 100644
> --- a/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> @@ -354,7 +354,6 @@ int qedr_create_gsi_qp(struct qedr_dev *dev, struct ib_qp_init_attr *attrs,
>  	/* the GSI CQ is handled by the driver so remove it from the FW */
>  	qedr_destroy_gsi_cq(dev, attrs);
>  	dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
> -	dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
> 
>  	DP_DEBUG(dev, QEDR_MSG_GSI, "created GSI QP %p\n", qp);
> 
> --
> 2.39.0


Thanks for making the change.

Acked-by: Alok Prasad <palok@...vell.com>