linux-kernel - Re: [PATCH v2] tools/nolibc: completely remove optional environ support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZK0B3Ekik+rKEyDj@1wt.eu>
Date:   Tue, 11 Jul 2023 09:16:44 +0200
From:   Willy Tarreau <w@....eu>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     linux-kernel@...r.kernel.org, Zhangjin Wu <falcon@...ylab.org>
Subject: Re: [PATCH v2] tools/nolibc: completely remove optional environ
 support

On Mon, Jul 10, 2023 at 08:01:34PM +0200, Thomas Weißschuh wrote:
> In commit 52e423f5b93e ("tools/nolibc: export environ as a weak symbol on i386")
> and friends the asm startup logic was extended to directly populate the
> "environ" array.
> 
> This makes it impossible for "environ" to be dropped by the linker.
> Therefore also drop the other logic to handle non-present "environ".
> 
> Also add a testcase to validate the initialization of environ.

Thank you Thomas, now pushed to the same branch.

Willy