[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <80a43533-f6d6-b498-b677-08f7e608155a@linaro.org>
Date: Tue, 11 Jul 2023 09:35:30 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jayesh Choudhary <j-choudhary@...com>, peda@...ntia.se,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
s-vadapalli@...com
Subject: Re: [PATCH] dt-bindings: ti-serdes-mux: Add defines for SERDES4 in
J784S4 SoC
On 11/07/2023 09:21, Jayesh Choudhary wrote:
>
>
> On 11/07/23 11:34, Krzysztof Kozlowski wrote:
>> On 11/07/2023 07:55, Jayesh Choudhary wrote:
>>> Hello Krzysztof,
>>>
>>> On 10/07/23 17:11, Krzysztof Kozlowski wrote:
>>>> On 10/07/2023 12:27, Jayesh Choudhary wrote:
>>>>> SERDES4 has 4 lanes. Add lane definitions for it.
>>>>>
>>>>> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
>>>>> ---
>>>>> include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++
>>>>
>>>> Where are the users of this binding constants? IOW, why do you need to
>>>> add these?
>>>>
>>>> I don't see users of existing constants either...
>>>>
>>>
>>> These constants are propagated in the idle-state property for the
>>> mux-controller node (named serdes_ln_ctrl) usually in the final
>>> board dts files and occasionally in the main dtsi files for TI SoCs.
>>
>> So they are not used.
>
> 'They' as in SERDES4 definition or others as well??
I made quick greps and it seems that none of the defines - existing and
new - are used. But here anyway we talk about this patch, which without
users does not have any rationale.
Best regards,
Krzysztof
Powered by blists - more mailing lists