linux-kernel - RE: [PATCH] perf build: Fix library not found error when using CSLIBS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN0PR12MB5953B9D303746370D9E3AB98B731A@MN0PR12MB5953.namprd12.prod.outlook.com>
Date:   Tue, 11 Jul 2023 08:28:31 +0000
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To:     James Clark <james.clark@....com>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>
CC:     "coresight@...ts.linaro.org" <coresight@...ts.linaro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Sarangi, Anirudha" <anirudha.sarangi@....com>
Subject: RE: [PATCH] perf build: Fix library not found error when using CSLIBS

> -----Original Message-----
> From: James Clark <james.clark@....com>
> Sent: Friday, July 7, 2023 9:16 PM
> To: linux-perf-users@...r.kernel.org; Pandey, Radhey Shyam
> <radhey.shyam.pandey@....com>
> Cc: coresight@...ts.linaro.org; James Clark <james.clark@....com>; Peter
> Zijlstra <peterz@...radead.org>; Ingo Molnar <mingo@...hat.com>;
> Arnaldo Carvalho de Melo <acme@...nel.org>; Mark Rutland
> <mark.rutland@....com>; Alexander Shishkin
> <alexander.shishkin@...ux.intel.com>; Jiri Olsa <jolsa@...nel.org>;
> Namhyung Kim <namhyung@...nel.org>; Ian Rogers <irogers@...gle.com>;
> Adrian Hunter <adrian.hunter@...el.com>; Uwe Kleine-König <uwe@...ine-
> koenig.org>; linux-kernel@...r.kernel.org
> Subject: [PATCH] perf build: Fix library not found error when using CSLIBS
> 
> -L only specifies the search path for libraries directly provided in the link line
> with -l. Because -lopencsd isn't specified, it's only linked because it's a
> dependency of -lopencsd_c_api. Dependencies like this are resolved using
> the default system search paths or -rpath-link=... rather than -L. This means
> that compilation only works if OpenCSD is installed to the system rather than
> provided with the CSLIBS (-L) option.
> 
> This could be fixed by adding -Wl,-rpath-link=$(CSLIBS) but that is less
> conventional than just adding -lopencsd to the link line so that it uses -L. -
> lopencsd seems to have been removed in commit ed17b1914978 ("perf
> tools: Drop requirement for libstdc++.so for libopencsd check") because it
> was thought that there was a chance compilation would work even if it didn't
> exist, but I think that only applies to libstdc++ so there is no harm to add it
> back. libopencsd.so and libopencsd_c_api.so would always exist together.
> 
> Testing
> =======
> 
> The following scenarios now all work:
> 
>  * Cross build with OpenCSD installed
>  * Cross build using CSLIBS=...
>  * Native build with OpenCSD installed
>  * Native build using CSLIBS=...
>  * Static cross build with OpenCSD installed
>  * Static cross build with CSLIBS=...
> 
> Reported-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
> Closes: https://lore.kernel.org/linux-arm-kernel/56905d7a-a91e-883a-b707-
> 9d5f686ba5f1@....com/
> Link: https://lore.kernel.org/all/36cc4dc6-bf4b-1093-1c0a-
> 876e368af183@...ine-koenig.org/
> Fixes: ed17b1914978 ("perf tools: Drop requirement for libstdc++.so for
> libopencsd check")
> Signed-off-by: James Clark <james.clark@....com>
> ---
>  tools/perf/Makefile.config | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index
> 0609c19caabd..c5db0de49868 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -155,9 +155,9 @@ FEATURE_CHECK_LDFLAGS-libcrypto = -lcrypto  ifdef
> CSINCLUDES
>    LIBOPENCSD_CFLAGS := -I$(CSINCLUDES)
>  endif
> -OPENCSDLIBS := -lopencsd_c_api
> +OPENCSDLIBS := -lopencsd_c_api -lopencsd
>  ifeq ($(findstring -static,${LDFLAGS}),-static)
> -  OPENCSDLIBS += -lopencsd -lstdc++
> +  OPENCSDLIBS += -lstdc++
>  endif
>  ifdef CSLIBS
>    LIBOPENCSD_LDFLAGS := -L$(CSLIBS)
> --
> 2.34.1

Tested-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Cross compiled for aarch64 on x86_64.

make ARCH=arm64 NO_LIBELF=1 NO_JVMTI=1 VF=1 CORESIGHT=1 -C  tools/perf

file <snip>/linux-xlnx/tools/perf/perf
perf: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), 
dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, 
BuildID[sha1]=ef7c524338577b14e7c0f914d882dec4d26e93a2, 
for GNU/Linux 3.14.0, with debug_info, not stripped

Thanks,
Radhey