[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230711085940.GA2220255@ik1-406-35019.vs.sakura.ne.jp>
Date: Tue, 11 Jul 2023 17:59:40 +0900
From: Naoya Horiguchi <naoya.horiguchi@...ux.dev>
To: Jiaqi Yan <jiaqiyan@...gle.com>
Cc: Matthew Wilcox <willy@...radead.org>, akpm@...ux-foundation.org,
mike.kravetz@...cle.com, naoya.horiguchi@....com,
songmuchun@...edance.com, shy828301@...il.com,
linmiaohe@...wei.com, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, duenwen@...gle.com,
axelrasmussen@...gle.com, jthoughton@...gle.com
Subject: Re: [PATCH v3 2/4] mm/hwpoison: check if a subpage of a hugetlb
folio is raw HWPOISON
On Mon, Jul 10, 2023 at 08:11:48AM -0700, Jiaqi Yan wrote:
> On Sun, Jul 9, 2023 at 5:21 PM Naoya Horiguchi
> <naoya.horiguchi@...ux.dev> wrote:
> >
> > On Fri, Jul 07, 2023 at 09:31:39PM +0100, Matthew Wilcox wrote:
> > > On Fri, Jul 07, 2023 at 08:19:02PM +0000, Jiaqi Yan wrote:
> > > > Add the functionality, is_raw_hwp_subpage, to tell if a subpage of a
> > >
> > > This is incorrect naming. "subpage" was needed before we had the
> > > folio concept, but it should not be used any more. We have folios
> > > and pages now.
> >
>
> Thanks for your comment, Matthew.
>
> > I think we can address the raw hwpoison page by the offset in folio/hugepage
> > to eliminate the concept of "subpage".
> >
> > >
> > > Also, abbreviating "hwpoison" as "hwp" seems like a bad idea to me.
> > > hwp is already used as an acronym by acpi, intel_pstate, some clock
> > > drivers, an ethernet driver, and a scsi driver.
> >
> > I originally introduced the abbreviation "hwp" to avoid using a lengthy
> > function name such as "folio_test_hugetlb_raw_hwpoison_unreliable()."
> > Therefore, I prefer using "rawhwp" instead of a longer form like
> > "raw_hwpoison," although I don't expect any confusion between "hwp" and
> > "rawhwp."
>
> These are names in my mind, what do you think?
> * is_rawhwp_page_in_hugepage
> * is_raw_hwpoison_page_in_hugepage // I prefer this one
This one is fine to me.
> * folio_test_hugetlb_raw_hwpoison_page
>
> > As for "hwp_walk", another user of "hwp" in in mm/memory-failure.c,
> > we can easily substitute it with "hwpoison_walk."
>
> In this "hwp_walk" case, I also prefer "hwpoison" than "hwp". I can
> create a separate renaming patch.
Great, thank you.
- Naoya Horiguchi
Powered by blists - more mailing lists