linux-kernel - Re: [PATCH 3/6] dt-bindings: thermal: tsens: Add ipq5332 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d614f142-7da2-50bf-36a1-11939c2c8189@quicinc.com>
Date:   Tue, 11 Jul 2023 14:54:34 +0530
From:   Praveenkumar I <quic_ipkumar@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <amitk@...nel.org>,
        <thara.gopinath@...il.com>, <rafael@...nel.org>,
        <daniel.lezcano@...aro.org>, <rui.zhang@...el.com>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <quic_varada@...cinc.com>
Subject: Re: [PATCH 3/6] dt-bindings: thermal: tsens: Add ipq5332 compatible


On 7/11/2023 1:36 AM, Krzysztof Kozlowski wrote:
> On 10/07/2023 12:37, Praveenkumar I wrote:
>> IPQ5332 uses TSENS v2.3.3 with combined interrupt. RPM is not
>> available in the SoC, hence adding new compatible to have the
>> sensor enablement and calibration function.>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
>> ---
>>   Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> index 8b7863c3989e..ee57713f6131 100644
>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> @@ -68,8 +68,10 @@ properties:
>>             - const: qcom,tsens-v2
>>   
>>         - description: v2 of TSENS with combined interrupt
>> -        enum:
>> -          - qcom,ipq8074-tsens
>> +        items:
> Drop items, you do not have multiple items.
Sure, will drop items.
>
>
>> +          - enum:
>> +              - qcom,ipq8074-tsens
>> +              - qcom,ipq5332-tsens
> Keep the order.
>>   
>>         - description: v2 of TSENS with combined interrupt
>>           items:
>> @@ -289,6 +291,7 @@ allOf:
>>             contains:
>>               enum:
>>                 - qcom,ipq8074-tsens
>> +              - qcom,ipq5332-tsens
> And here
>
>>       then:
>>         properties:
>>           interrupts:
>> @@ -304,6 +307,7 @@ allOf:
>>             contains:
>>               enum:
>>                 - qcom,ipq8074-tsens
>> +              - qcom,ipq5332-tsens
> And here.

Sure, will keep the order.

--
Thanks,
Praveenkumar
>
>>                 - qcom,tsens-v0_1
>>                 - qcom,tsens-v1
>>                 - qcom,tsens-v2
> Best regards,
> Krzysztof
>