[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1090089b-2fa9-9781-51a8-38957e261bfd@linaro.org>
Date: Tue, 11 Jul 2023 13:09:27 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Thomas Zimmermann <tzimmermann@...e.de>, javierm@...hat.com,
noralf@...nnes.org
Cc: Daniel Vetter <daniel.vetter@...ll.ch>,
dri-devel@...ts.freedesktop.org,
Mikko Perttunen <mperttunen@...dia.com>,
Thierry Reding <thierry.reding@...il.com>,
amd-gfx@...ts.freedesktop.org, linux-samsung-soc@...r.kernel.org,
Russell King <linux@...linux.org.uk>,
Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
Kyungmin Park <kyungmin.park@...sung.com>,
Paul Schyska <pschyska@...il.com>,
Torsten Krah <krah.tm@...il.com>,
linux-arm-msm@...r.kernel.org,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Maxime Ripard <mripard@...nel.org>,
linux-tegra@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
freedreno@...ts.freedesktop.org,
"Pan, Xinhui" <Xinhui.Pan@....com>,
Seung-Woo Kim <sw0312.kim@...sung.com>,
linux-kernel@...r.kernel.org, stable@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Alex Deucher <alexander.deucher@....com>,
Moritz Duge <MoritzDuge@...ahilft.de>,
Christian König <christian.koenig@....com>
Subject: Re: [PATCH] drm/client: Send hotplug event after registering a client
On 11/07/2023 09:07, Thomas Zimmermann wrote:
> Hi
>
> Am 10.07.23 um 23:11 schrieb Dmitry Baryshkov:
> [...]
>>> ---
>>> drivers/gpu/drm/armada/armada_fbdev.c | 4 ----
>>> drivers/gpu/drm/drm_client.c | 21 +++++++++++++++++++++
>>> drivers/gpu/drm/drm_fbdev_dma.c | 4 ----
>>> drivers/gpu/drm/drm_fbdev_generic.c | 4 ----
>>> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 4 ----
>>> drivers/gpu/drm/gma500/fbdev.c | 4 ----
>>> drivers/gpu/drm/msm/msm_fbdev.c | 4 ----
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> # msm
>
> Thanks.
>
>>
>>> drivers/gpu/drm/omapdrm/omap_fbdev.c | 4 ----
>>> drivers/gpu/drm/radeon/radeon_fbdev.c | 4 ----
>>> drivers/gpu/drm/tegra/fbdev.c | 4 ----
>>> 10 files changed, 21 insertions(+), 36 deletions(-)
>>
>> BTW: As you have been clearing this area. I see that significant
>> amount of DRM drivers use exactly the same code for
>> msm_fbdev_client_funcs and for the significant part of
>> foo_fbdev_setup(). Do you have any plans for moving that into a
>> library / generic code? If not, I can take a look at crafting the patch.
>>
>
> You're not the first to ask. :) I've so far not attempted to address
> this duplication. I've been bitten by premature helperization before, so
> I wanted to wait a bit longer. A lot of the fbdev and client code is
> changing quite a bit. After things stabilized, I want to to try to do
> some more code sharing.
Ack, thank you for sharing this.
--
With best wishes
Dmitry
Powered by blists - more mailing lists