[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4431d779-e6e7-aff1-5cf8-4147de974d8d@linux.dev>
Date: Tue, 11 Jul 2023 19:06:20 +0800
From: Chengming Zhou <chengming.zhou@...ux.dev>
To: Christoph Hellwig <hch@....de>
Cc: axboe@...nel.dk, ming.lei@...hat.com, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, zhouchengming@...edance.com
Subject: Re: [PATCH 1/2] blk-flush: fix rq->flush.seq for post-flush requests
On 2023/7/10 21:30, Christoph Hellwig wrote:
> On Mon, Jul 10, 2023 at 02:47:04PM +0800, chengming.zhou@...ux.dev wrote:
>> From: Chengming Zhou <zhouchengming@...edance.com>
>>
>> If the policy == (REQ_FSEQ_DATA | REQ_FSEQ_POSTFLUSH), it means that the
>> data sequence and post-flush sequence need to be done for this request.
>>
>> The rq->flush.seq should record what sequences have been done (or don't
>> need to be done). So in this case, pre-flush doesn't need to be done,
>> we should init rq->flush.seq to REQ_FSEQ_PREFLUSH not REQ_FSEQ_POSTFLUSH.
>>
>> Of course, this doesn't cause any problem in fact, since pre-flush and
>> post-flush sequence do the same thing for now.
>
> I wonder if it really doesn't cause any problems, but the change for
> sure looks good:
>
> Reviewed-by: Christoph Hellwig <hch@....de>
>
> It should probably go before your other flush optimizations and maybe
> grow a fixes tag.
Ok, will add a Fixes tag and send it as a separate patch since it's a bug fix.
Thanks.
Powered by blists - more mailing lists