linux-kernel - Re: [PATCH v3 3/5] arch: Register fchmodat4, usually as syscall 451

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <55fee4b7-41f0-4f24-ad0e-a4527486bad1@app.fastmail.com>
Date:   Tue, 11 Jul 2023 13:31:44 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Alexey Gladkov" <legion@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-api@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        "Alexander Viro" <viro@...iv.linux.org.uk>
Cc:     "Palmer Dabbelt" <palmer@...ive.com>,
        "James E . J . Bottomley" <James.Bottomley@...senPartnership.com>,
        "Arnaldo Carvalho de Melo" <acme@...nel.org>,
        "Alexander Shishkin" <alexander.shishkin@...ux.intel.com>,
        "Jens Axboe" <axboe@...nel.dk>,
        "Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
        "Christian Borntraeger" <borntraeger@...ibm.com>,
        "Borislav Petkov" <bp@...en8.de>,
        "Catalin Marinas" <catalin.marinas@....com>, christian@...uner.io,
        "Rich Felker" <dalias@...c.org>,
        "David S . Miller" <davem@...emloft.net>,
        "Deepa Dinamani" <deepa.kernel@...il.com>,
        "Helge Deller" <deller@....de>,
        "David Howells" <dhowells@...hat.com>, fenghua.yu@...el.com,
        firoz.khan@...aro.org, "Florian Weimer" <fweimer@...hat.com>,
        "Geert Uytterhoeven" <geert@...ux-m68k.org>, glebfm@...linux.org,
        gor@...ux.ibm.com, hare@...e.com, heiko.carstens@...ibm.com,
        "H. Peter Anvin" <hpa@...or.com>,
        "Ivan Kokshaysky" <ink@...assic.park.msu.ru>, jhogan@...nel.org,
        "Kim Phillips" <kim.phillips@....com>, ldv@...linux.org,
        linux-alpha@...r.kernel.org,
        Linux-Arch <linux-arch@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-ia64@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
        linux-parisc@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-sh@...r.kernel.org, "Russell King" <linux@...linux.org.uk>,
        linuxppc-dev@...ts.ozlabs.org, "Andy Lutomirski" <luto@...nel.org>,
        "Matt Turner" <mattst88@...il.com>,
        "Ingo Molnar" <mingo@...hat.com>,
        "Michal Simek" <monstr@...str.eu>,
        "Michael Ellerman" <mpe@...erman.id.au>,
        "Namhyung Kim" <namhyung@...nel.org>, paul.burton@...s.com,
        "Paul Mackerras" <paulus@...ba.org>,
        "Peter Zijlstra" <peterz@...radead.org>, ralf@...ux-mips.org,
        rth@...ddle.net, schwidefsky@...ibm.com,
        sparclinux@...r.kernel.org, stefan@...er.ch,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Tony Luck" <tony.luck@...el.com>, tycho@...ho.ws,
        "Will Deacon" <will@...nel.org>, x86@...nel.org,
        "Yoshinori Sato" <ysato@...rs.sourceforge.jp>
Subject: Re: [PATCH v3 3/5] arch: Register fchmodat4, usually as syscall 451

On Tue, Jul 11, 2023, at 13:25, Alexey Gladkov wrote:
> From: Palmer Dabbelt <palmer@...ive.com>
>
> This registers the new fchmodat4 syscall in most places as nuber 451,
> with alpha being the exception where it's 561.  I found all these sites
> by grepping for fspick, which I assume has found me everything.
>
> Signed-off-by: Palmer Dabbelt <palmer@...ive.com>
> Signed-off-by: Alexey Gladkov <legion@...nel.org>

In linux-6.5-rc1, number 451 is used for __NR_cachestat, the
next free one at the moment is 452.

>  arch/arm/tools/syscall.tbl                  | 1 +
>  arch/arm64/include/asm/unistd32.h           | 2 ++

Unfortunately, you still also need to change __NR_compat_syscalls
in arch/arm64/include/asm/unistd.h. Aside from these two issues,
your patch is the correct way to hook up a new syscall.

   Arnd