linux-kernel - Re: [PATCH V2] arm64: dts: qcom: sa8775p-ride: Update L4C parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Jul 2023 13:40:42 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Naveen Kumar Goud Arepalli <quic_narepall@...cinc.com>,
        quic_nitirawa@...cinc.com, agross@...nel.org, andersson@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] arm64: dts: qcom: sa8775p-ride: Update L4C parameters

On 11.07.2023 12:59, Naveen Kumar Goud Arepalli wrote:
> L4c is the supply for UFS vccq, As per UFS spec range of vccq is
> 1.14V to 1.26V, There are stability issues when operating at
> marginal voltage. Hence configure the min and max vccq voltages
> to 1.2V.
> 
> Signed-off-by: Naveen Kumar Goud Arepalli <quic_narepall@...cinc.com>
> ---
Couple of things I'd like you to fix in the future:

1. you sent a v2 minutes after v1, with no changelog or reference

(ideally you should include something like:

Changes since v1:
- foo
- bar
- baz

Link to v1: ...)

You can use the b4 tool [1] which makes this really easy for everyone!

2. You overtook the series from your colleague. It's okay, but:

- you should have mentioned this (see point 1)
- it's fine for your colleagues to send your patches, so long as all
  of the co-authors AND the person sending add their Signed-off-by tags

Also, check out [2].

Aside from that, this patch looks sane to me.

Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>


[1] https://b4.docs.kernel.org/en/latest/index.html
[2] https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Konrad

>  arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> index ab767cfa51ff..26f5a4e0ffed 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> @@ -153,8 +153,8 @@
>  
>  		vreg_l4c: ldo4 {
>  			regulator-name = "vreg_l4c";
> -			regulator-min-microvolt = <1100000>;
> -			regulator-max-microvolt = <1300000>;
> +			regulator-min-microvolt = <1200000>;
> +			regulator-max-microvolt = <1200000>;
>  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>  			/*
>  			 * FIXME: This should have regulator-allow-set-load but