[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87pm4ybqct.fsf@oldenburg.str.redhat.com>
Date: Tue, 11 Jul 2023 14:10:58 +0200
From: Florian Weimer <fweimer@...hat.com>
To: Alexey Gladkov <legion@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
linux-api@...r.kernel.org, linux-fsdevel@...r.kernel.org,
viro@...iv.linux.org.uk, James.Bottomley@...senPartnership.com,
acme@...nel.org, alexander.shishkin@...ux.intel.com,
axboe@...nel.dk, benh@...nel.crashing.org, borntraeger@...ibm.com,
bp@...en8.de, catalin.marinas@....com, christian@...uner.io,
dalias@...c.org, davem@...emloft.net, deepa.kernel@...il.com,
deller@....de, dhowells@...hat.com, fenghua.yu@...el.com,
firoz.khan@...aro.org, geert@...ux-m68k.org, glebfm@...linux.org,
gor@...ux.ibm.com, hare@...e.com, heiko.carstens@...ibm.com,
hpa@...or.com, ink@...assic.park.msu.ru, jhogan@...nel.org,
kim.phillips@....com, ldv@...linux.org,
linux-alpha@...r.kernel.org, linux-arch@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-ia64@...r.kernel.org,
linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
linux-parisc@...r.kernel.org, linux-s390@...r.kernel.org,
linux-sh@...r.kernel.org, linux@...linux.org.uk,
linuxppc-dev@...ts.ozlabs.org, luto@...nel.org, mattst88@...il.com,
mingo@...hat.com, monstr@...str.eu, mpe@...erman.id.au,
namhyung@...nel.org, palmer@...ive.com, paul.burton@...s.com,
paulus@...ba.org, peterz@...radead.org, ralf@...ux-mips.org,
rth@...ddle.net, schwidefsky@...ibm.com,
sparclinux@...r.kernel.org, stefan@...er.ch, tglx@...utronix.de,
tony.luck@...el.com, tycho@...ho.ws, will@...nel.org,
x86@...nel.org, ysato@...rs.sourceforge.jp
Subject: Re: [PATCH v3 5/5] selftests: add fchmodat4(2) selftest
* Alexey Gladkov:
> The test marks as skipped if a syscall with the AT_SYMLINK_NOFOLLOW flag
> fails. This is because not all filesystems support changing the mode
> bits of symlinks properly. These filesystems return an error but change
> the mode bits:
>
> newfstatat(4, "regfile", {st_mode=S_IFREG|0640, st_size=0, ...}, AT_SYMLINK_NOFOLLOW) = 0
> newfstatat(4, "symlink", {st_mode=S_IFLNK|0777, st_size=7, ...}, AT_SYMLINK_NOFOLLOW) = 0
> syscall_0x1c3(0x4, 0x55fa1f244396, 0x180, 0x100, 0x55fa1f24438e, 0x34) = -1 EOPNOTSUPP (Operation not supported)
> newfstatat(4, "regfile", {st_mode=S_IFREG|0640, st_size=0, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> This happens with btrfs and xfs:
>
> $ /kernel/tools/testing/selftests/fchmodat4/fchmodat4_test
> TAP version 13
> 1..1
> ok 1 # SKIP fchmodat4(symlink)
> # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
>
> $ stat /tmp/ksft-fchmodat4.*/symlink
> File: /tmp/ksft-fchmodat4.3NCqlE/symlink -> regfile
> Size: 7 Blocks: 0 IO Block: 4096 symbolic link
> Device: 7,0 Inode: 133 Links: 1
> Access: (0600/lrw-------) Uid: ( 0/ root) Gid: ( 0/ root)
>
> Signed-off-by: Alexey Gladkov <legion@...nel.org>
This looks like a bug in those file systems?
As an extra test, “echo 3 > /proc/sys/vm/drop_caches” sometimes has
strange effects in such cases because the bits are not actually stored
on disk, only in the dentry cache.
Thanks,
Florian
Powered by blists - more mailing lists