linux-kernel - RE: [PATCH v2] gpio: mmio: fix calculation of bgpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH2PR12MB38958A4ABF8397A53D68F41AD731A@CH2PR12MB3895.namprd12.prod.outlook.com>
Date:   Tue, 11 Jul 2023 12:23:40 +0000
From:   Asmaa Mnebhi <asmaa@...dia.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "brgl@...ev.pl" <brgl@...ev.pl>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        David Thompson <davthompson@...dia.com>
Subject: RE: [PATCH v2] gpio: mmio: fix calculation of bgpio_bits

> > If the "ngpios" property is specified, bgpio_bits is calculated as the
> > round up value of ngpio. At the moment, the only requirement specified
> > is that the round up value must be a multiple of 8 but it should also
> > be a power of 2 because we provide accessors based on the bank size in
> > bgpio_setup_accessors().
> 
> Is this a fixup for the other patch? If so, then why did you split them again?
> 
Apologies, I might have misunderstood your previous comment. I thought you asked me to split it again so that it is a rebased continuation of the approved old patches.
To avoid any further misunderstandings on my part , could you please confirm the following:
1) I will create one patch combining both
2) The tag for this one patch will be "[PATCH v2] gpio: mmio: handle "ngpios" properly in bgpio_init()"
And Reviewed-By Andy and Linus.
3) I will add in the commit message , a changelog section as shown below:
Signed-off-by: Asmaa Mnebhi <asmaa@...dia.com>
---
V1->v2:
- rebase + combination of the 2 patches.