linux-kernel - Re: [PATCH 15/18] soc: ti: Mover power-domain drivers to the genpd dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230711124901.7b3tw374n7eldjpj@puppy>
Date:   Tue, 11 Jul 2023 07:49:01 -0500
From:   Nishanth Menon <nm@...com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     Tony Lindgren <tony@...mide.com>, Arnd Bergmann <arnd@...db.de>,
        Olof Johansson <olof@...om.net>, <linux-pm@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Tero Kristo <kristo@...nel.org>
Subject: Re: [PATCH 15/18] soc: ti: Mover power-domain drivers to the genpd
 dir

On 11:16-20230711, Ulf Hansson wrote:
> On Fri, 7 Jul 2023 at 19:50, Nishanth Menon <nm@...com> wrote:
> >
> > On 16:04-20230707, Ulf Hansson wrote:
> > > Cc: Nishanth Menon <nm@...com>
> > > Cc: Santosh Shilimkar <ssantosh@...nel.org>
> > > Cc: Tero Kristo <kristo@...nel.org>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> > > ---
> > >  MAINTAINERS                                   | 3 ++-
> > >  drivers/genpd/Makefile                        | 1 +
> > >  drivers/genpd/ti/Makefile                     | 3 +++
> > >  drivers/{soc => genpd}/ti/omap_prm.c          | 0
> > >  drivers/{soc => genpd}/ti/ti_sci_pm_domains.c | 0
> > >  drivers/soc/ti/Makefile                       | 2 --
> > >  6 files changed, 6 insertions(+), 3 deletions(-)
> > >  create mode 100644 drivers/genpd/ti/Makefile
> > >  rename drivers/{soc => genpd}/ti/omap_prm.c (100%)
> > >  rename drivers/{soc => genpd}/ti/ti_sci_pm_domains.c (100%)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 9e580df3e5db..3cf16ffac892 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -21101,7 +21101,7 @@ F:    drivers/irqchip/irq-ti-sci-inta.c
> > >  F:   drivers/irqchip/irq-ti-sci-intr.c
> > >  F:   drivers/reset/reset-ti-sci.c
> > >  F:   drivers/soc/ti/ti_sci_inta_msi.c
> > > -F:   drivers/soc/ti/ti_sci_pm_domains.c
> > > +F:   drivers/genpd/ti/ti_sci_pm_domains.c
> > >  F:   include/dt-bindings/soc/ti,sci_pm_domain.h
> > >  F:   include/linux/soc/ti/ti_sci_inta_msi.h
> > >  F:   include/linux/soc/ti/ti_sci_protocol.h
> > > @@ -21335,6 +21335,7 @@ L:    linux-kernel@...r.kernel.org
> > >  L:   linux-arm-kernel@...ts.infradead.org (moderated for non-subscribers)
> > >  S:   Maintained
> > >  T:   git git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
> > > +F:   drivers/genpd/ti/omap_prm.c
> >
> > Probably the wrong place for this as omap_prm is'nt a keystone navigator
> > driver set. Maybe Tony has a suggestion?
> 
> I guess we could add it to the OMAP2+ section then?

That would be my suggestion.

> 
> In any case, I suggest we consider that as a separate patch on top, as
> I am just obeying to the existing pattern that the get_maintainers
> script provides.
> 

OK. otherwise, this looks good to me.

Reviewed-by: Nishanth Menon <nm@...com>
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D