linux-kernel - Re: [PATCH v4 2/2] Input: cap11xx - add advanced sensitivity settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b085b09-bff9-7b71-6984-3dfd27a235a6@axis.com>
Date:   Tue, 11 Jul 2023 15:05:52 +0200
From:   Jiri Valek - 2N <jiriv@...s.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:     <krzysztof.kozlowski+dt@...aro.org>, <devicetree@...r.kernel.org>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <robh+dt@...nel.org>, <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v4 2/2] Input: cap11xx - add advanced sensitivity settings

On 6/28/23 21:06, Dmitry Torokhov wrote:
> Hi Jiri,
> 
> On Tue, Jun 27, 2023 at 08:53:16AM +0200, Jiri Valek - 2N wrote:
>> @@ -439,7 +589,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
>>  	priv->idev->id.bustype = BUS_I2C;
>>  	priv->idev->evbit[0] = BIT_MASK(EV_KEY);
>>  
>> -	if (of_property_read_bool(node, "autorepeat"))
>> +	if (of_property_read_bool(dev->of_node, "autorepeat"))
> 
> It would be good to have this driver switched from of_property_*() to
> device_property_() API.

Yes, I do this after my changes.
> 
>>  		__set_bit(EV_REP, priv->idev->evbit);
>>  
>>  	for (i = 0; i < cap->num_channels; i++)
>> @@ -474,14 +624,8 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
>>  	if (error)
>>  		return error;
>>  
>> -	irq = irq_of_parse_and_map(node, 0);
>> -	if (!irq) {
>> -		dev_err(dev, "Unable to parse or map IRQ\n");
>> -		return -ENXIO;
>> -	}
>> -
>> -	error = devm_request_threaded_irq(dev, irq, NULL, cap11xx_thread_func,
>> -					  IRQF_ONESHOT, dev_name(dev), priv);
>> +	error = devm_request_threaded_irq(dev, i2c_client->irq, NULL,
>> +					cap11xx_thread_func, IRQF_ONESHOT, dev_name(dev), priv);
> 
> I would prefer this change be a separate patch.

Agree, I will prepare separate patch

> 
> Thanks.
> 

BR
Jiri