linux-kernel - Re: [PATCH] HID: logitech-hidpp: rework one more time the retries attempts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f53de7c-e9db-6bf5-6e9e-65edadd4d754@leemhuis.info>
Date:   Tue, 11 Jul 2023 15:56:02 +0200
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@...mhuis.info>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linux regressions mailing list <regressions@...ts.linux.dev>
Cc:     Bastien Nocera <hadess@...ess.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        Filipe Laíns <lains@...eup.net>,
        Jiri Kosina <jikos@...nel.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: rework one more time the retries
 attempts



On 11.07.23 15:40, Benjamin Tissoires wrote:
> On Tue, Jul 11, 2023 at 3:10 PM Linux regression tracking (Thorsten
> Leemhuis) <regressions@...mhuis.info> wrote:
>>
>> On 26.06.23 16:02, Benjamin Tissoires wrote:
>>> On Sun, Jun 25, 2023 at 10:30 AM Bastien Nocera <hadess@...ess.net> wrote:
>>>> On Fri, 2023-06-23 at 10:37 +0200, Benjamin Tissoires wrote:
>>>>> On Jun 21 2023, Greg KH wrote:
>>>>>> On Wed, Jun 21, 2023 at 11:42:30AM +0200, Benjamin Tissoires wrote:
>>>>>>> Make the code looks less like Pascal.
>>>>>>>
>>>>>>> Extract the internal code inside a helper function, fix the
>>>>>>> initialization of the parameters used in the helper function
>>>>>>> (`hidpp->answer_available` was not reset and `*response` wasn't
>>>>>>> too),
>>>>>>> and use a `do {...} while();` loop.
>>>>>>>
>>>>>>> Fixes: 586e8fede795 ("HID: logitech-hidpp: Retry commands when
>>>>>>> device is busy")
>>>>>>> Cc: stable@...r.kernel.org
>>>>>>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
>>>>>>> ---
>>>>>>> as requested by
>>>>>>> https://lore.kernel.org/all/CAHk-=wiMbF38KCNhPFiargenpSBoecSXTLQACKS2UMyo_Vu2ww@mail.gmail.com/
>>>>>>> This is a rewrite of that particular piece of code.
>>>>>>> ---
>>>>>>>  drivers/hid/hid-logitech-hidpp.c | 102 +++++++++++++++++++++++--
>>>>>>> --------------
>>>>>>>  1 file changed, 61 insertions(+), 41 deletions(-)
>>> [...]
>>>
>>> Some people on the Bz were able to reproduce with multiple reboots.
>>> But it's not as urgent as previously, and we were close to the 6.4
>>> final when I sent it. I'll make sure this goes into 6.5 and gets
>>> proper stable backports FWIW.
>>
>> Did that happen? Doesn't look like it from here, but maybe I'm missing
>> something. Where there maybe other changes to resolve the remaining
>> problems some users encounter sporadically since the urgent fixes went in?
> 
> No, there were no other changes that could have solved this. I guess
> the randomness of the problem makes it way harder to detect and to
> reproduce.
> 
> I'll send a v2 of that patch with the reviews today or tomorrow and we
> can probably get it through the current 6.5 cycle.

Great, many thx!

Ciao, Thorsten