linux-kernel - Re: [PATCH 07/13] ALSA: intel-dsp-config: Convert to PCI device IDs defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Jul 2023 17:12:49 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH 07/13] ALSA: intel-dsp-config: Convert to PCI device IDs
 defines

On Tue, Jul 11, 2023 at 04:09:42PM +0200, Amadeusz Sławiński wrote:
> On 7/11/2023 4:00 PM, Andy Shevchenko wrote:
> > On Tue, Jul 11, 2023 at 02:57:20PM +0200, Amadeusz Sławiński wrote:

...

> > > -		.device = 0x119a,
> > > +		.device = PCI_DEVICE_ID_INTEL_ADSP_TNG,
> > 
> > Yeah, somebody familiar with Intel history of SST/HDA/wtf should really
> > tell why HDA code is using this ID. Does it mean that SST implies HDA
> > always? Only for this (or this family of) platform?
> > 
> > It might affect the ID naming, but otherwise it's orthogonal to the series.
> > 
> 
> There were few early devices where DSP was separate unit:
> Haswell, Broadwell - where we use ACPI to load (SND_SOC_INTEL_CATPT) audio
> driver, Tangier/Merrifield - where ACPI or PCI is used to load
> (SND_SST_ATOM_HIFI2_PLATFORM_PCI) audio driver.
> All further generations are HDA devices with integrated DSP. This causes all
> the weirdness ;)

Maybe we should stick with SST in the name? At least that's how Tangier TRM
titles it.

-- 
With Best Regards,
Andy Shevchenko