[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c3ea2043-5d02-3a6f-ecb7-fb90d989bc6f@linaro.org>
Date: Wed, 12 Jul 2023 16:16:01 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Amit Pundir <amit.pundir@...aro.org>,
Bjorn Andersson <andersson@...nel.org>,
Andy Gross <agross@...nel.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Caleb Connolly <caleb.connolly@...aro.org>,
Bryan Donoghue <bryan.odonoghue@...aro.org>,
Rob Clark <robdclark@...il.com>,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Sean Paul <sean@...rly.run>,
Marijn Suijten <marijn.suijten@...ainline.org>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Krishna Manikandan <quic_mkrishn@...cinc.com>
Cc: dri-devel <dri-devel@...ts.freedesktop.org>,
freedreno <freedreno@...ts.freedesktop.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
dt <devicetree@...r.kernel.org>,
lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: display/msm: qcom,sdm845-mdss: add
memory-region property
On 12/07/2023 15:02, Amit Pundir wrote:
> Add and document the reserved memory region property
> in the qcom,sdm845-mdss schema.
>
> Signed-off-by: Amit Pundir <amit.pundir@...aro.org>
Please keep consistent versioning, so this is new patch in v4.
> ---
> .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> index 6ecb00920d7f..3ea1dbd7e317 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> @@ -39,6 +39,11 @@ properties:
> interconnect-names:
> maxItems: 2
>
> + memory-region:
> + maxItems: 1
> + description:
> + Phandle to a node describing a reserved memory region.
Your description says nothing new. It's entirely redundant/obvious.
Instead please describe what reserved memory is expected to be here.
Best regards,
Krzysztof
Powered by blists - more mailing lists