[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <598d39ca-c1be-a57f-9ab5-d90403c78cd0@igalia.com>
Date: Wed, 12 Jul 2023 11:21:42 -0300
From: Maira Canal <mcanal@...lia.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
Ville Syrjälä <ville.syrjala@...ux.intel.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/gem-fb-helper: Consistenly use drm_dbg_kms()
On 7/12/23 10:42, Geert Uytterhoeven wrote:
> All debug messages in drm_gem_framebuffer_helper.c use drm_dbg_kms(),
> except for one, which uses drm_dbg().
> Replace the outlier by drm_dbg_kms() to restore consistency.
>
> Fixes: c91acda3a380bcaf ("drm/gem: Check for valid formats")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
Reviewed-by: Maíra Canal <mcanal@...lia.com>
Thanks for sending this fix!
Best Regards,
- Maíra
> ---
> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> index b8a615a138cd675f..3bdb6ba37ff42fb6 100644
> --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> @@ -168,8 +168,8 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev,
> if (drm_drv_uses_atomic_modeset(dev) &&
> !drm_any_plane_has_format(dev, mode_cmd->pixel_format,
> mode_cmd->modifier[0])) {
> - drm_dbg(dev, "Unsupported pixel format %p4cc / modifier 0x%llx\n",
> - &mode_cmd->pixel_format, mode_cmd->modifier[0]);
> + drm_dbg_kms(dev, "Unsupported pixel format %p4cc / modifier 0x%llx\n",
> + &mode_cmd->pixel_format, mode_cmd->modifier[0]);
> return -EINVAL;
> }
>
Powered by blists - more mailing lists