[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20230712142350.11638-1-machel@vivo.com>
Date: Wed, 12 Jul 2023 22:23:37 +0800
From: Wang Ming <machel@...o.com>
To: Jassi Brar <jassisinghbrar@...il.com>, linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com, Wang Ming <machel@...o.com>
Subject: [PATCH v1] mailbox:Fix error checking for debugfs_create_dir() in mbox_test_add_debugfs()
In case of failure, debugfs_create_dir() does not return NULL, but
an error pointer. Most incorrect error checks were fixed,but the
one in mbox_test_add_debugfs() was forgotten.
Signed-off-by: Wang Ming <machel@...o.com>
---
drivers/mailbox/mailbox-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
index fc6a12a51b40..ae9861c57fb1 100644
--- a/drivers/mailbox/mailbox-test.c
+++ b/drivers/mailbox/mailbox-test.c
@@ -268,7 +268,7 @@ static int mbox_test_add_debugfs(struct platform_device *pdev,
return 0;
tdev->root_debugfs_dir = debugfs_create_dir(dev_name(&pdev->dev), NULL);
- if (!tdev->root_debugfs_dir) {
+ if (IS_ERR(tdev->root_debugfs_dir)) {
dev_err(&pdev->dev, "Failed to create Mailbox debugfs\n");
return -EINVAL;
}
--
2.25.1
Powered by blists - more mailing lists