linux-kernel - Re: 回复: [PATCH v2] lib:Fix more error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7871b526-3cd4-9c78-298c-b03c95277b2d@infradead.org>
Date:   Tue, 11 Jul 2023 19:58:06 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     王明-软件底层技术部 
        <machel@...o.com>, LKML <linux-kernel@...r.kernel.org>
Cc:     "opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: 回复: [PATCH v2] lib:Fix more error checking for debugfs_create_dir()



On 7/11/23 18:20, 王明-软件底层技术部 wrote:
> Hi Randy.
> The only maintainers I obtained using get_maintainer.pl were LKML, and there seems to be no other maintainers
> Do you have any good suggestions?: )
> 

Use 'git log lib/test_fpu.c' to see who merges patches to it.

> ~Ming
> -----邮件原件-----
> 发件人: Randy Dunlap <rdunlap@...radead.org> 
> 发送时间: 2023年7月12日 3:33
> 收件人: 王明-软件底层技术部 <machel@...o.com>; linux-kernel@...r.kernel.org
> 抄送: opensource.kernel <opensource.kernel@...o.com>
> 主题: Re: [PATCH v2] lib:Fix more error checking for debugfs_create_dir()
> 
> [Some people who received this message don't often get email from rdunlap@...radead.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hi--
> 
> On 7/11/23 04:16, Wang Ming wrote:
>> In case of failure, debugfs_create_dir() does not return NULL, but an 
>> error pointer.  Most incorrect error checks were fixed, but the one in 
>> test_fpu_init() was forgotten.
>>
>> Fix the remaining error check.
>>
>> Signed-off-by: Wang Ming <machel@...o.com>
> 
> You need to send this to some maintainer who can merge it, so please an appropriate maintainer to send it to.
> 
> Thanks.
> 
>> ---
>>  lib/test_fpu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/test_fpu.c b/lib/test_fpu.c index 
>> e82db19fed84..5d6aa4691b4a 100644
>> --- a/lib/test_fpu.c
>> +++ b/lib/test_fpu.c
>> @@ -69,7 +69,7 @@ static struct dentry *selftest_dir;  static int 
>> __init test_fpu_init(void)  {
>>       selftest_dir = debugfs_create_dir("selftest_helpers", NULL);
>> -     if (!selftest_dir)
>> +     if (IS_ERR(selftest_dir))
>>               return -ENOMEM;
>>
>>       debugfs_create_file_unsafe("test_fpu", 0444, selftest_dir, NULL,
> 
> --
> ~Randy

-- 
~Randy