linux-kernel - Re: 回复: [PATCH v1] iommu: fix parameter check in tegra_smmu_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ZK7BcFc-sdm15Sv9@orome>
Date:   Wed, 12 Jul 2023 17:06:24 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     杜敏杰 <duminjie@...o.com>
Cc:     Krishna Reddy <vdumpa@...dia.com>, Joerg Roedel <joro@...tes.org>,
        Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "open list:TEGRA IOMMU DRIVERS" <linux-tegra@...r.kernel.org>,
        "open list:IOMMU SUBSYSTEM" <iommu@...ts.linux.dev>,
        open list <linux-kernel@...r.kernel.org>,
        "opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: 回复: [PATCH v1] iommu: fix
 parameter check in tegra_smmu_debugfs_init()

On Wed, Jul 12, 2023 at 12:37:02PM +0000, 杜敏杰 wrote:
> Hi Thierry!
> 
> >I think we can just drop the error check altogether since
> >debugfs_create_file() will simply return early if smmu->debugfs is an error pointer.
> 
> So do you mean maybe delete the smmu->debugfs check is better?
> Maybe I can resubmit a new patch.

Yes, I think that would be preferable.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)