linux-kernel - RE: [EXT] Re: [net PATCH] octeontx2-af: Install TC filter rules in hardware based on priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB5216261D93D2AD3A336976AEDB36A@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date:   Wed, 12 Jul 2023 15:06:22 +0000
From:   Suman Ghosh <sumang@...vell.com>
To:     Alexander Lobakin <aleksander.lobakin@...el.com>
CC:     Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [net PATCH] octeontx2-af: Install TC filter rules in
 hardware based on priority


>From: Suman Ghosh <sumang@...vell.com>
>Date: Mon, 3 Jul 2023 17:35:36 +0530
>
>> As of today, hardware does not support installing tc filter rules
>> based on priority. This patch fixes the issue and install the hardware
>> rules based on priority. The final hardware rules will not be
>> dependent on rule installation order, it will be strictly priority
>> based, same as software.
>>
>> Signed-off-by: Suman Ghosh <sumang@...vell.com>
>1. Targeted net (fixes), but no "Fixes:" tag.
>2. 350 locs of changes in a single commit. Is it so atomic, so that
>   even can't be split logically?
>   Esp. given that it's claimed as a fix, not a feature. Single 350-locs
>   fixes do happen, but *very* rarely.
[Suman] After reconsideration, I think this should go as a feature as it is a new capability introduced.
I will push the patch in net-next. But yes, all the changes are atomic only.
>
>Thanks,
>Olek