linux-kernel - Re: [PATCH 13/13] ASoC: Intel: sst: Convert to PCI device IDs defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZK7MqGyGYJ9eMlH1@smile.fi.intel.com>
Date:   Wed, 12 Jul 2023 18:54:16 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH 13/13] ASoC: Intel: sst: Convert to PCI device IDs defines

On Wed, Jul 12, 2023 at 02:19:47PM +0200, Amadeusz Sławiński wrote:
> On 7/11/2023 4:33 PM, Andy Shevchenko wrote:
> > On Tue, Jul 11, 2023 at 02:57:26PM +0200, Amadeusz Sławiński wrote:
> > > Use PCI device IDs from pci_ids.h header.

...

> > >   	switch (sst->dev_id) {
> > > -	case SST_MRFLD_PCI_ID:
> > > +	case PCI_DEVICE_ID_INTEL_ADSP_TNG:
> > >   	case SST_BYT_ACPI_ID:
> > >   	case SST_CHV_ACPI_ID:
> > 
> > I think this needs a bit more, i.e. replacing the rest with respective PCI IDs.
> > 
> > All three will be defined with SST prefix, which makes sense to me.
> > 
> > ACPI here is a bit misleading, but correct. The ACPI specification assumes that
> > respective part of the ID space covers 100% of PCI ID space.
> > 
> > I have briefly checked the code and it seems that ID is used externally only
> > for PCI case, so we may simply use the lower 16 bits of the ACPI _HID for the
> > context.
> 
> Do I understand correctly that I should just do:
> #define PCI_DEVICE_ID_INTEL_SST_BYT	0x0F28
> #define PCI_DEVICE_ID_INTEL_SST_CHV	0x22A8
> and use those IDs instead?

Correct!

-- 
With Best Regards,
Andy Shevchenko