linux-kernel - Re: [PATCH v1] android:Fix error checking for debugfs_create_dir() in binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023071257-patronize-unfeeling-cbe5@gregkh>
Date:   Wed, 12 Jul 2023 18:35:10 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Wang Ming <machel@...o.com>
Cc:     Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <brauner@...nel.org>,
        Carlos Llamas <cmllamas@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] android:Fix error checking for debugfs_create_dir()
 in binder_init()

On Wed, Jul 12, 2023 at 09:39:07PM +0800, Wang Ming wrote:
> debugfs_create_dir() does not return NULL,but it is
> possible to return error pointer. Most incorrect error checks
> were fixed,but the one in binder_init() was forgotten.
> 
> Fix the remaining error check.
> 
> Signed-off-by: Wang Ming <machel@...o.com>
> ---
>  drivers/android/binder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 486c8271cab7..3b5309484df6 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6566,7 +6566,7 @@ static int __init binder_init(void)
>  	atomic_set(&binder_transaction_log_failed.cur, ~0U);
>  
>  	binder_debugfs_dir_entry_root = debugfs_create_dir("binder", NULL);
> -	if (binder_debugfs_dir_entry_root) {
> +	if (!IS_ERR(binder_debugfs_dir_entry_root)) {

Again, no need to check this at all.

thanks,

greg k-h