linux-kernel - Re: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Jul 2023 20:24:47 +0200
From:   Alejandro Tafalla <atafalla@...on.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     jic23@...nel.org, lars@...afoo.de, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval

On miércoles, 12 de julio de 2023 13:04:05 (CEST) Lorenzo Bianconi wrote:
> > The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI
> > support is not enabled to allow executing iio_read_mount_matrix in the
> > probe function.
> > 
> > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
> > 
> > Signed-off-by: Alejandro Tafalla <atafalla@...on.com>
> > ---
> > 
> >  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > b/drivers/iio/imu/ st_lsm6dsx/st_lsm6dsx_core.c
> > index 6a18b363cf73..62bc3ee783fb 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct
> > device *dev,
> > 
> >  static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> >  
> >  					  struct
> > 
> > iio_mount_matrix *orientation)
> > 
> >  {
> > 
> > -	return false;
> > +	return true;
> 
> I would say it should return something like -EOPNOTSUPP.
> 
> Regards,
> Lorenzo
> 
> >  }
> >  
> >  #endif

Hi, thank you for the review. I'll send a v2 with a better solution that uses 
error codes.

Alejandro.