[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1ac2fb68-02e0-ddfe-87aa-fcd093779009@linaro.org>
Date: Wed, 12 Jul 2023 20:37:30 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Pankaj Gupta <pankaj.gupta@....com>, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de, clin@...e.com,
conor+dt@...nel.org, pierre.gondois@....com, ping.bai@....com,
xiaoning.wang@....com, wei.fang@....com, peng.fan@....com,
haibo.chen@....com, festevam@...il.com, linux-imx@....com,
davem@...emloft.net, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, gaurav.jain@....com,
alexander.stein@...tq-group.com, sahil.malhotra@....com,
aisheng.dong@....com, V.Sethi@....com
Subject: Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp secure enclave
firmware
On 12/07/2023 14:12, Pankaj Gupta wrote:
> Added support for NXP secure enclave called EdgeLock Enclave
> firmware (se-fw) for imx8ulp-evk.
>
> Signed-off-by: Pankaj Gupta <pankaj.gupta@....com>
> ---
> arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index 3ddc0f3125b3..10ed31974a6f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -114,7 +114,7 @@ sosc: clock-sosc {
> #clock-cells = <0>;
> };
>
> - sram@...1f000 {
> + sram0: sram@...1f000 {
> compatible = "mmio-sram";
> reg = <0x0 0x2201f000 0x0 0x1000>;
>
> @@ -161,6 +161,16 @@ s4muap: mailbox@...20000 {
> #mbox-cells = <2>;
> };
>
> + ele_fw: se-fw {
> + compatible = "fsl,imx-ele";
> + mboxes = <&s4muap 0 0 &s4muap 1 0>;
> + mbox-names = "tx", "rx";
> + fsl,mu-did = <7>;
> + fsl,mu-id = <2>;
> + sram-pool = <&sram0>;
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
It's by default.
Best regards,
Krzysztof
Powered by blists - more mailing lists