linux-kernel - Re: [PATCH][next] selftests/mm: mkdirty: Fix incorrect position of #endif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60f2ef09-53b2-6bf8-9cd0-3b639ac7b765@redhat.com>
Date:   Wed, 12 Jul 2023 21:10:47 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] selftests/mm: mkdirty: Fix incorrect position of
 #endif

On 12.07.23 15:46, Colin Ian King wrote:
> The #endif is the wrong side of a } causing a build failure when
> __NR_userfaultfd is not defined. Fix this by moving the #end to
> enclose the }
> 
> Fixes: 9eac40fc0cc7 ("selftests/mm: mkdirty: test behavior of (pte|pmd)_mkdirty on VMAs without write permissions")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   tools/testing/selftests/mm/mkdirty.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/mkdirty.c b/tools/testing/selftests/mm/mkdirty.c
> index 6d71d972997b..301abb99e027 100644
> --- a/tools/testing/selftests/mm/mkdirty.c
> +++ b/tools/testing/selftests/mm/mkdirty.c
> @@ -321,8 +321,8 @@ static void test_uffdio_copy(void)
>   munmap:
>   	munmap(dst, pagesize);
>   	free(src);
> -#endif /* __NR_userfaultfd */
>   }
> +#endif /* __NR_userfaultfd */
>   
>   int main(void)
>   {

Ouch, thanks!

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb