linux-kernel - Re: [PATCH] ARM: mm: Fix warnings in context.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZK795eVoadj/wARO@shell.armlinux.org.uk>
Date:   Wed, 12 Jul 2023 20:24:21 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     shijie001@...suo.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: mm: Fix warnings in context.c

On Wed, Jul 12, 2023 at 05:06:32PM +0800, shijie001@...suo.com wrote:
> The following checkpatch warning is removed:
> WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h>
> 
> Signed-off-by: Jie Shi <shijie001@...suo.com>
> ---
>  arch/arm/mm/context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/context.c b/arch/arm/mm/context.c
> index 4204ffa2d104..c84ad6c786e7 100644
> --- a/arch/arm/mm/context.c
> +++ b/arch/arm/mm/context.c
> @@ -13,7 +13,7 @@
>  #include <linux/smp.h>
>  #include <linux/percpu.h>
> 
> -#include <asm/mmu_context.h>
> +#include <linux/mmu_context.h>
>  #include <asm/smp_plat.h>
>  #include <asm/thread_notify.h>
>  #include <asm/tlbflush.h>
> 

Probably haven't noticed, but linux/ includes are all grouped together,
and asm/ includes are all grouped together. Please keep that.

Also, is it really a necessary change, when arch/arm/mm/context.c is
only implementing the interfaces provided by asm/mmu_context.h? I think
the warning is wrong in this case and should never be fixed as things
currently stand.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!