linux-kernel - Re: [PATCH] hwmon: Remove strlcpy occurences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADmuW3WfOwAD2MLmNkua5d3Tzjh3RWDSjZomQ_Tu6ucJ+B+bqA@mail.gmail.com>
Date:   Wed, 12 Jul 2023 15:25:53 -0400
From:   Azeem Shaikh <azeemshaikh38@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        linux-hardening@...r.kernel.org, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH] hwmon: Remove strlcpy occurences

On Wed, Jul 12, 2023 at 2:04 PM Kees Cook <keescook@...omium.org> wrote:
>
> On Wed, Jul 12, 2023 at 08:16:39AM -0700, Guenter Roeck wrote:
> > On 7/12/23 07:44, Azeem Shaikh wrote:
> > > [...]
> > > +   len = strlen(result);
> > >     return simple_read_from_buffer(buf, count, ppos, tbuf, len);
> >
> > This still copies tbuf, meaning all those constant strings won't actually
> > be reported.
>
> Ah dang, thanks for catching that. Yeah, "tbuf" should be replaced by
> "result" in the simple_read_from_buffer().
>

Thanks for review folks, will send out a v2 shortly.