linux-kernel - Re: [PATCH] net: wwan: t7xx: Add AP CLDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZK8EN4dfZgICvPl8@corigine.com>
Date:   Wed, 12 Jul 2023 20:51:19 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
Cc:     loic.poulain@...aro.org, ryazanov.s.a@...il.com,
        johannes@...solutions.net, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        jinjian.song@...ocom.com, haijun.liu@...iatek.com,
        chandrashekar.devegowda@...el.com, matthias.bgg@...il.com,
        chiranjeevi.rapolu@...ux.intel.com,
        ricardo.martinez@...ux.intel.com,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        m.chetan.kumar@...ux.intel.com, linuxwwan@...el.com,
        angelogioacchino.delregno@...labora.com
Subject: Re: [PATCH] net: wwan: t7xx: Add AP CLDMA

+ maintainers and MLs as advised by get_maintainers.pl

On Tue, Jul 11, 2023 at 08:28:13AM +0200, Jose Ignacio Tornos Martinez wrote:
> At this moment with the current status, t7xx is not functional due to
> problems like this after connection, if there is no activity:
> [   57.370534] mtk_t7xx 0000:72:00.0: [PM] SAP suspend error: -110
> [   57.370581] mtk_t7xx 0000:72:00.0: can't suspend
>     (t7xx_pci_pm_runtime_suspend [mtk_t7xx] returned -110)
> because after this, the traffic no longer works.
> 
> The complete series 'net: wwan: t7xx: fw flashing & coredump support'
> was reverted because of issues with the pci implementation.
> In order to have at least the modem working, it would be enough if just
> the first commit of the series is re-applied:
> d20ef656f994 net: wwan: t7xx: Add AP CLDMA
> With that, the Application Processor would be controlled, correctly
> suspended and the commented problems would be fixed (I am testing here
> like this with no related issue).
> 
> This commit is independent of the others and not related to the
> commented pci implementation for the new features: fw flashing and
> coredump collection.
> 
> Use v2 patch version of d20ef656f994 as JinJian Song suggests
> (https://patchwork.kernel.org/project/netdevbpf/patch/20230105154215.198828-1-m.chetan.kumar@linux.intel.com/).
> 
> Original text from the commit that would be re-applied:
> 
>     d20ef656f994 net: wwan: t7xx: Add AP CLDMA
>     Author: Haijun Liu <haijun.liu@...iatek.com>
>     Date:   Tue Aug 16 09:53:28 2022 +0530
> 
>     The t7xx device contains two Cross Layer DMA (CLDMA) interfaces to
>     communicate with AP and Modem processors respectively. So far only
>     MD-CLDMA was being used, this patch enables AP-CLDMA.
> 
>     Rename small Application Processor (sAP) to AP.
> 
>     Signed-off-by: Haijun Liu <haijun.liu@...iatek.com>
>     Co-developed-by: Madhusmita Sahu <madhusmita.sahu@...el.com>
>     Signed-off-by: Madhusmita Sahu <madhusmita.sahu@...el.com>
>     Signed-off-by: Moises Veleta <moises.veleta@...ux.intel.com>
>     Signed-off-by: Devegowda Chandrashekar <chandrashekar.devegowda@...el.com>
>     Signed-off-by: M Chetan Kumar <m.chetan.kumar@...ux.intel.com>
>     Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
>     Reviewed-by: Sergey Ryazanov <ryazanov.s.a@...il.com>
>     Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>