[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bdf08528-1e45-0b7a-e617-63151aa89e0d@intel.com>
Date: Wed, 12 Jul 2023 13:57:25 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Wang Ming <machel@...o.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
"David S. Miller" <davem@...emloft.net>,
"Eric Dumazet" <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
CC: <opensource.kernel@...o.com>
Subject: Re: [PATCH v2] net:Fix an NULL vs IS_ERR() bug for
debugfs_create_dir() in i40e_dbg_init()
On 7/12/2023 5:19 AM, Wang Ming wrote:
Please designate a tree for the patch (net or net-next) [1].
If you could include the driver (i40e) in the commit title as well.
Also, a nit, but the title is a bit long, seems like it could be a bit
more succinct.
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. Most incorrect error checks were fixed,
> but the one in i40e_dbg_init() was forgotten.
>
> Fix the remaining error check.
As it's a fix, there should be a Fixes tag as well.
> Signed-off-by: Wang Ming <machel@...o.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> index 9954493cd448..62497f5565c5 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> @@ -1839,7 +1839,7 @@ void i40e_dbg_pf_exit(struct i40e_pf *pf)
> void i40e_dbg_init(void)
> {
> i40e_dbg_root = debugfs_create_dir(i40e_driver_name, NULL);
> - if (!i40e_dbg_root)
> + if (IS_ERR(i40e_dbg_root))
> pr_info("init of debugfs failed\n");
> }
>
[1]
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
Powered by blists - more mailing lists