linux-kernel - RE: [PATCH] clocksource: Fix warnings in mshyperv.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR21MB16885FB2E77FC9ADB1C8B48DD736A@BYAPR21MB1688.namprd21.prod.outlook.com>
Date:   Wed, 12 Jul 2023 21:06:30 +0000
From:   "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
To:     "huzhi001@...suo.com" <huzhi001@...suo.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        Dexuan Cui <decui@...rosoft.com>
CC:     "hpa@...or.com" <hpa@...or.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] clocksource: Fix warnings in mshyperv.h

From: huzhi001@...suo.com <huzhi001@...suo.com> Sent: Wednesday, July 12, 2023 4:23 AM
> 
> The following checkpatch warnings are removed:
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>

The "Subject:" of the patch should probably start with "x86/hyperv",
not "clocksource".  Usually I look back at the commit history of a
particular file and try to be consistent with the Subject: prefix that
has been used in the past.  "x86/hyperv" is typical for this
include file.

Other than that,

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
> 
> Signed-off-by: ZhiHu <huzhi001@...suo.com>
> ---
>   arch/x86/include/asm/mshyperv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/mshyperv.h
> b/arch/x86/include/asm/mshyperv.h
> index 88d9ef98e087..fa83d88e4c99 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -5,7 +5,7 @@
>   #include <linux/types.h>
>   #include <linux/nmi.h>
>   #include <linux/msi.h>
> -#include <asm/io.h>
> +#include <linux/io.h>
>   #include <asm/hyperv-tlfs.h>
>   #include <asm/nospec-branch.h>
>   #include <asm/paravirt.h>