linux-kernel - Re: [PATCH v1] regmap-irq: Fix out-of-bounds access when allocating config buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Jul 2023 23:06:26 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Russell King <linux@...linux.org.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        Saravana Kannan <saravanak@...gle.com>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Aidan MacDonald <aidanmacdonald.0x0@...il.com>,
        "Isaac J. Manjarres" <isaacmanjarres@...gle.com>
Cc:     Amit Pundir <amit.pundir@...aro.org>,
        John Stultz <jstultz@...gle.com>, stable@...r.kernel.org,
        Catalin Marinas <catalin.marinas@....com>,
        kernel-team@...roid.com,
        Russell King <rmk+kernel@....linux.org.uk>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] regmap-irq: Fix out-of-bounds access when
 allocating config buffers

On Tue, 11 Jul 2023 12:30:58 -0700, Isaac J. Manjarres wrote:
> When allocating the 2D array for handling IRQ type registers in
> regmap_add_irq_chip_fwnode(), the intent is to allocate a matrix
> with num_config_bases rows and num_config_regs columns.
> 
> This is currently handled by allocating a buffer to hold a pointer for
> each row (i.e. num_config_bases). After that, the logic attempts to
> allocate the memory required to hold the register configuration for
> each row. However, instead of doing this allocation for each row
> (i.e. num_config_bases allocations), the logic erroneously does this
> allocation num_config_regs number of times.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/1] regmap-irq: Fix out-of-bounds access when allocating config buffers
      commit: 963b54df82b6d6206d7def273390bf3f7af558e1

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark