linux-kernel - Re: [PATCH] usb: dwc3: Disable AutoRetry controller feature for dwc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Jul 2023 23:02:08 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Jakub Vaněk <linuxtardis@...il.com>
CC:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Mauro Ribeiro <mauro.ribeiro@...dkernel.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH] usb: dwc3: Disable AutoRetry controller feature for
 dwc_usb3 v2.00a

On Thu, Jul 13, 2023, Jakub Vaněk wrote:
> Hi Thinh,
> 
> On Tue, 2023-07-11 at 21:48 +0000, Thinh Nguyen wrote:
> > Hi Jakub,
> > 
> > On Thu, Jul 06, 2023, Jakub Vaněk wrote:
> > > On Wed, 2023-07-05 at 22:47 +0000, Thinh Nguyen wrote:
> > > > I brought up this inquiry internally. Please wait as I need to
> > > > review
> > > > this further. The handling for this may be different depending on
> > > > the
> > > > team's feedback.
> > > > 
> > > 
> > > OK; feel free to contact me if I could be of any help.
> > > 
> > 
> > Sorry for the delay. After discussion, this behavior is the same
> > across
> > different controller versions. The consensus is to disable this
> > feature
> > altoghether. There will not be any noticeable performance impact.
> > 
> > Would you mind revise the patch to disable this feature for all?
> 
> Not at all, I have sent a new revision of the patch:
> https://urldefense.com/v3/__https://lore.kernel.org/linux-usb/20230712224037.24948-1-linuxtardis@gmail.com/__;!!A4F2R9G_pg!euvmvJVr_AMCpyd59tiav4Co4u8p0TKzsLq0W7yKoyIlN_K7WFv2GP57wXmsddsJoxsEq6_Bhx8yp5gG8vAqebKhkw$ 
> 
> Reverting the commit altogether seemed preferable to me to updating the
> revision-specific patch. However, if the other way would be better, I
> can send an updated revision.
> 

Reverting it is fine also. We'll keep the default setting from
CoreConsultant.

Thanks,
Thinh