[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a7761c1e-9327-38f7-8e7b-0b3c3007668e@linaro.org>
Date: Wed, 12 Jul 2023 07:25:54 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Kevin Lu <luminlong@....com>, broonie@...nel.org,
lgirdwood@...il.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
tiwai@...e.com
Cc: kevin-lu@...com, shenghao-ding@...com, alsa-devel@...a-project.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] ASoC: dt-bindings: Add tas2505 audio amplifier
On 12/07/2023 06:40, Kevin Lu wrote:
> Create tas2505.yaml for tas2505.
>
> Signed-off-by: Kevin Lu <luminlong@....com>
> ---
> .../devicetree/bindings/sound/tas2505.yaml | 72 +++++++++++++++++++
> 1 file changed, 72 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/tas2505.yaml
Filename like compatible.
>
> diff --git a/Documentation/devicetree/bindings/sound/tas2505.yaml b/Documentation/devicetree/bindings/sound/tas2505.yaml
> new file mode 100644
> index 0000000..6cc3fe4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/tas2505.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2019 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/sound/tas2505.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
Drop quotes
> +
> +title: Texas Instruments TAS2505 Mono Audio Amplifier
> +
> +maintainers:
> + - Kevin Lu <kevin-lu@...com>
> +
> +description: |
> + The TAS2505 is a mono Class-D speaker amp that supports both Digital
> + and Analog inputs. The device is ideal for automotive instrument cluster,
> + emergency call (eCall), and telematics applications. Direct I2S input
> + removes the need for an external DAC in the audio signal path.
> + An on-chip PLL provides the high speed clock needed by the DSP.
> + The volume level is register controlled.
> +
> + Specifications about the audio amplifier can be found at:
> + https://www.ti.com/lit/gpn/tas2505
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tas2505
Why are you adding duplicated binding?
> +
> + reg:
> + maxItems: 1
> + description: |
> + I2C address of the device can be set to 0x18.> +
> + reset-gpios:
> + maxItems: 1
> + description: GPIO used to reset the device.
Drop description, it's obvious.
> +
> + clock-source:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Sets TDM clock sourse.
source, but anyway that is not the way to set clocks. Use "clocks"
property for your future bindings.
> + enum:
> + - 0 # Select MLCK
> + - 1 # Select BLCK
> +
> + '#sound-dai-cells':
> + # The codec has a single DAI, the #sound-dai-cells=<1>; case is left in for backward
> + # compatibility but is deprecated.
This is the first submission so there is no "deprecated" or "backwards
compatibility".
Best regards,
Krzysztof
Powered by blists - more mailing lists