[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CY5PR11MB6257F77DBF1D123FAD0DF4689736A@CY5PR11MB6257.namprd11.prod.outlook.com>
Date: Wed, 12 Jul 2023 06:15:01 +0000
From: "Lu, Brent" <brent.lu@...el.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC: "Rojewski, Cezary" <cezary.rojewski@...el.com>,
Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
Bard Liao <yung-chuan.liao@...ux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
Mark Brown <broonie@...nel.org>,
"Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
"Zhi, Yong" <yong.zhi@...el.com>,
"Bhat, Uday M" <uday.m.bhat@...el.com>,
Ajye Huang <ajye_huang@...pal.corp-partner.google.com>,
Arnd Bergmann <arnd@...db.de>,
"Song, Gongjun" <gongjun.song@...el.com>,
Terry Cheong <htcheong@...omium.org>,
"Chiang, Mac" <mac.chiang@...el.com>,
"R, Dharageswari" <dharageswari.r@...el.com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
ye xingchen <ye.xingchen@....com.cn>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] ASoC: Intel: sof_rt5682: add jsl_rt5650 board config
> > + {
> > + .id = "10EC5650",
> > + .drv_name = "jsl_rt5650",
> > + .machine_quirk = snd_soc_acpi_codec_list,
> > + .quirk_data = &rt5650_spk,
> > + .sof_tplg_filename = "sof-jsl-rt5650-dual.tplg",
>
> what does 'dual' mean in this context? it's not something we've used before
> so a comment would be needed IMHO.
>
> two DAIs, two codecs?
Dual I2S. Should we remove it? Just sof-jsl-rt5650.tplg?
Regards,
Brent
Powered by blists - more mailing lists