linux-kernel - Re: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Jul 2023 08:46:13 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        linux-mm@...ck.org, schnelle@...ux.ibm.com, vkoul@...nel.org,
        eli.billauer@...il.com, arnd@...db.de, gregkh@...uxfoundation.org,
        derek.kiernan@....com, dragan.cvetic@....com,
        linux@...inikbrodowski.net, Jonathan.Cameron@...wei.com,
        linus.walleij@...aro.org, tsbogend@...ha.franken.de,
        joyce.ooi@...el.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, tglx@...utronix.de,
        maz@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
        robh+dt@...nel.org, frowand.list@...il.com,
        kernel test robot <lkp@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM

On 07/11/23 at 06:17pm, Simon Horman wrote:
> On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote:
> > On s390 systems (aka mainframes), it has classic channel devices for
> > networking and permanent storage that are currently even more common
> > than PCI devices. Hence it could have a fully functional s390 kernel
> > with CONFIG_PCI=n, then the relevant iomem mapping functions
> > [including ioremap(), devm_ioremap(), etc.] are not available.
> > 
> > Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built
> > to cause below compiling error if PCI is unset:
> > 
> > ------
> > ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined!
> > ------
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/
> > Signed-off-by: Baoquan He <bhe@...hat.com>
> 
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Tested-by: Simon Horman <simon.horman@...igine.com> # build-tested

Thanks, Simon.

> 
> I wonder if this should also have:
> 
>   Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig")

Agree, it's worth having Fixes tag.