linux-kernel - Re: [PATCH 02/27] thermal/drivers/armada: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230712104649.3d843fb3@xps-13>
Date:   Wed, 12 Jul 2023 10:46:49 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Yangtao Li <frank.li@...o.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/27] thermal/drivers/armada: Convert to platform
 remove callback returning void

Hi Yangtao,

frank.li@...o.com wrote on Wed, 12 Jul 2023 16:12:33 +0800:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Acked-by: Miquel Raynal <miquel.raynal@...tlin.com>

> ---
>  drivers/thermal/armada_thermal.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> index 9f6dc4fc9112..94783e374d37 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -964,19 +964,17 @@ static int armada_thermal_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int armada_thermal_exit(struct platform_device *pdev)
> +static void armada_thermal_exit(struct platform_device *pdev)
>  {
>  	struct armada_drvdata *drvdata = platform_get_drvdata(pdev);
>  
>  	if (drvdata->type == LEGACY)
>  		thermal_zone_device_unregister(drvdata->data.tz);
> -
> -	return 0;
>  }
>  
>  static struct platform_driver armada_thermal_driver = {
>  	.probe = armada_thermal_probe,
> -	.remove = armada_thermal_exit,
> +	.remove_new = armada_thermal_exit,
>  	.driver = {
>  		.name = "armada_thermal",
>  		.of_match_table = armada_thermal_id_table,


Thanks,
Miquèl