linux-kernel - Re: [PATCH] gpio: 74xx-mmio: remove unneeded platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VenLV_+LMvxRcpdRGN5eBK9+ZBoGLaOox+XpOvaUP5Csw@mail.gmail.com>
Date:   Wed, 12 Jul 2023 13:04:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandru Ardelean <alex@...uggie.ro>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linus.walleij@...aro.org, brgl@...ev.pl, andy@...nel.org
Subject: Re: [PATCH] gpio: 74xx-mmio: remove unneeded platform_set_drvdata() call

On Wed, Jul 12, 2023 at 12:49 PM Alexandru Ardelean <alex@...uggie.ro> wrote:
>
> The platform_set_drvdata() was needed when the driver had an explicit
> remove function.
> That function got removed a while back, so we don't need to keep a pointer
> (on 'dev->driver_data') for the private data of the driver anymore.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Alexandru Ardelean <alex@...uggie.ro>
> ---
>  drivers/gpio/gpio-74xx-mmio.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c
> index 0464f1ecd20d..c7ac5a9ffb1f 100644
> --- a/drivers/gpio/gpio-74xx-mmio.c
> +++ b/drivers/gpio/gpio-74xx-mmio.c
> @@ -135,8 +135,6 @@ static int mmio_74xx_gpio_probe(struct platform_device *pdev)
>         priv->gc.ngpio = MMIO_74XX_BIT_CNT(priv->flags);
>         priv->gc.owner = THIS_MODULE;
>
> -       platform_set_drvdata(pdev, priv);
> -
>         return devm_gpiochip_add_data(&pdev->dev, &priv->gc, priv);
>  }
>
> --
> 2.40.1
>


-- 
With Best Regards,
Andy Shevchenko