linux-kernel - Re: [PATCH v2 2/3] arm64: dts: ti: Add reserved memory for watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02dfb5562da08fa95c8eba9c727dfc8bbaad07be.camel@siemens.com>
Date:   Wed, 12 Jul 2023 01:48:09 +0000
From:   "Li, Hua Qian" <HuaQian.Li@...mens.com>
To:     "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     "kristo@...nel.org" <kristo@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "huaqianlee@...il.com" <huaqianlee@...il.com>,
        "nm@...com" <nm@...com>, "vigneshr@...com" <vigneshr@...com>,
        "Kiszka, Jan" <jan.kiszka@...mens.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "Su, Bao Cheng" <baocheng.su@...mens.com>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] arm64: dts: ti: Add reserved memory for watchdog

On Tue, 2023-07-11 at 11:24 +0200, Krzysztof Kozlowski wrote:
> On 11/07/2023 11:17, huaqian.li@...mens.com wrote:
> > From: Li Hua Qian <huaqian.li@...mens.com>
> > 
> > This patch adds a reserved memory for the TI AM65X platform
> > watchdog to
> > reserve the specific info, triggering the watchdog reset in last
> > boot,
> > to know if the board reboot is due to a watchdog reset.
> > 
> > Signed-off-by: Li Hua Qian <huaqian.li@...mens.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 11
> > +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > index e26bd988e522..77380e52a334 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@...00000 {
> >                         alignment = <0x1000>;
> >                         no-map;
> >                 };
> > +
> > +               /* To reserve the power-on(PON) reason for watchdog
> > reset */
> > +               wdt_reset_memory_region: wdt-memory@...00000 {
> > +                       reg = <0x00 0xa2200000 0x00 0x00001000>;
> > +                       no-map;
> > +               };
> >         };
> >  
> >         leds {
> > @@ -718,3 +724,8 @@ &mcu_r5fss0_core1 {
> >                         <&mcu_r5fss0_core1_memory_region>;
> >         mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
> >  };
> > +
> > +&mcu_rti1 {
> > +       reg = <0x0 0x40610000 0x0 0x100>,
> > +             <0x0 0xa2200000 0x0 0x1000>;
> 
> That's a total mess. reserved memory and IO address space. Nope.
> 
> 
> 
> Best regards,
> Krzysztof
> 
Yes, I misunderstood the advice. I intend to roll back as I mentioned
in my last email. Any new suggestions please let me know, thank you!

Best regards,
Li Hua Qian