linux-kernel - RE: [PATCH v2] ASoC: Intel: sof_rt5682: add jsl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Jul 2023 01:59:45 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC:     "Rojewski, Cezary" <cezary.rojewski@...el.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        "Zhi, Yong" <yong.zhi@...el.com>,
        "Bhat, Uday M" <uday.m.bhat@...el.com>,
        "Song, Gongjun" <gongjun.song@...el.com>,
        Ajye Huang <ajye_huang@...pal.corp-partner.google.com>,
        Arnd Bergmann <arnd@...db.de>,
        Terry Cheong <htcheong@...omium.org>,
        "R, Dharageswari" <dharageswari.r@...el.com>,
        "Chiang, Mac" <mac.chiang@...el.com>,
        "Kuninori Morimoto" <kuninori.morimoto.gx@...esas.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] ASoC: Intel: sof_rt5682: add jsl_rt5650 board config

> > int sof_rt5682_codec_init(struct snd_soc_pcm_runtime *rtd)
> >  	struct sof_card_private *ctx = snd_soc_card_get_drvdata(rtd->card);
> >  	struct snd_soc_component *component = asoc_rtd_to_codec(rtd,
> 0)->component;
> >  	struct snd_soc_jack *jack;
> > -	int ret;
> > +	int ret, extra;
> 
> two lines, and rename to e.g. extra_jack_data
> 
> 
Will do.

> > +	if (sof_rt5682_quirk & SOF_RT5650_HEADPHONE_CODEC_PRESENT) {
> > +		extra = SND_JACK_MICROPHONE | SND_JACK_BTN_0;
> > +		ret = snd_soc_component_set_jack(component, jack,
> &extra);
> 
> I am a bit confused on why this wasn't set for rt5682?
> 
Rt5650's driver needs this parameter to specify whether button detection is
required while rt5682's driver does not need it.

> >
> > +static struct snd_soc_dai_link_component rt5650_components[] = {
> > +	{
> > +		.name = "i2c-10EC5650:00",
> > +		.dai_name = "rt5645-aif1",
> > +	},
> > +	{
> > +		.name = "i2c-10EC5650:00",
> > +		.dai_name = "rt5645-aif2",
> > +	}
> > +};
> 
> can we move these definitions to realtek_common.c, chances are other
> boards will also use this codec. Thanks!

Rt5650 is a all-in-one codec which supports headphone and speaker output. It's
unlikely to be paired with other headphone codec. Suggest keeping it in sof_rt5682.c


Regards,
Brent